Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP WIP WIP #116

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

WIP WIP WIP #116

wants to merge 9 commits into from

Conversation

irevoire
Copy link
Member

@irevoire irevoire commented Mar 25, 2025

Fixes #117

  • Since we’re not breaking random descendant, the frozen reader only contains the useful number of items that fits in RAM instead of containing all items

TODO:

  • When we insert the items in the tree, we must retrieve all the descendants that became too big
  • We should also add to this list of descendant the list of new made tree node that contains the whole DB.
  • Once this is done, we can start the loop over this whole list and treat each item's one by one
  • Then test and fix
    • We should remove descendants when they became too small and check again the reuse_node_id test
    • When remove an item that was a branch of a split node we don’t rewrite the node and don’t remove the item
  • Then parallelize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split nodes do not shrink correctly
1 participant