This repository was archived by the owner on Jul 10, 2023. It is now read-only.
fix: don't apply region taxes to custom gift cards #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nostalgic-booth-1cf149 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for palmes-staging-admin ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for tekla-admin ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for elastic-keller-bcaedb ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for preeminent-gingersnap-0af4e1 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I'm in the admin UI and want to create a custom gift card, it shouldn't remove balance from the number I just input. I would understand charging taxes in a purchase, but if a store owner wants to give a gift card to someone with a round number ,they shouldn't have to finagle with the admin UI to get a nice round number.
https://www.loom.com/share/b81cee853ffb48f88d8792bc87d81aeb
Also fixing an issue where the "Balance Remaining" was showing the original amount in the table.