-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(na): add manual link checker scripts #1769
base: main
Are you sure you want to change the base?
Conversation
When running steps 1-3 (
In your video, it seems like you are on the |
The branch is show wrong on the first CLI (see More importantly, let's figure why it didn't work for you! What does it say after you run the script? For example, for me it says Also, I realize that it should just hit production to get the |
Thanks @mrjones-plip. As in the logs I shared above, the script returns |
Aha - yes - you already put that log info in your earlier comment 😅 - thanks for the reminder. I'll dig into this! |
Thanks again @andrablaj ! Ok - I didn't figure out what the issue is, but realized it will be MUCH faster to just scrape the prod URLs from the site map and then scrape the I've updated the ticket body to be accurate on how to test! |
@mrjones-plip I won't be able to review this today, sorry. I will look into this PR tomorrow. |
I ran the steps in the description locally (by using the branch associated with this PR), and after running the script, I get the following logs:
Two questions:
|
oops - let me try and figure our |
@andrablaj - the
with this output?
And that you get a
Thanks! |
Description
This PR add manual link checker scripts. While I'd wanted to do this in CI, I needed to review a recent PR which had 51 changes - this was too many to check by hand, so I resurrected the scripts I'd been using already, but just a veneer of polish on them and sent them off to live in this PR to be merged
Testing
Steps
hugo
cd .github/scripts; ./check.urls.sh
You'll see output like this
Demo video
(NB - this is ~4x faster than real-time)
linkcheck.F.webm
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.