wallDistanceMethod Flag Added To daOptions #796
Merged
+417
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 14, 2025 14:47
…ult. This option is a flag for manually computing distance terms for CHT. I added a dedicated unit test for this (solid, incompressible, compressible) and removed it from previous unit tests.
… directory it was already in. This has been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the flag "wallDistanceMethod" to daOptions to use the custom/manual distance calculation. The byUnitArea option remains in the function dictionary. Additionally, incompressible, compressible, and solid unit tests have been added which test the wallDistanceMethod flag as well as using byUnitArea: False. All tests for wallDistanceMethod and byUnitArea have been moved to runUnitTests_DACustomCHT.py.