Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allows to the user insert text,numbers or spaces when write in Tag TextBox (Angel) #265

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

AngelGarcia
Copy link
Collaborator

When the user is adding a new issue. The user only can write text, numbers or spaces in the text box, not , . / @ ...

@sabad66
Copy link
Collaborator

sabad66 commented Apr 1, 2011

Hi Angel,
What exactly did you change/update here? Not sure why it shows all of these commits in here since they are already in the mainline. Weird... Might be because of line endings or something. Are you using Notepad++ on Windows? If so, go to settings->preferences->New Document/Default Directory, then change the format section to be Unix.

Anyways, this pull request is kind of hard to complete because the diff doesn't show your changes correctly (you obviously didn't change 1780 lines of code) and therefore we can't see what your code changes were.

Not sure if there's an easy way to fix this, but here is what I would do:
a) save a copy of the files that you know you changed (on your desktop or something)
b) make a new branch (git branch tag-validation), then switch to it (git checkout tag-validation)
c) do a pull from the mainline (git pull upstream master) (assuming you have a remote to the mainline called upstream)
d) make the changes again
e) commit to your local repo, push to your origin repo (git push origin HEAD:tag-validation), close this pull request, then create a new pull request for these new commits

You should also include the issue you fixed, as well as how to test your code changes in the pull request.

Just a friendly suggestion here.. take it or leave it, but this is probably why nobody has completed this yet :)

  • Dori

@AngelGarcia
Copy link
Collaborator Author

Thank you Dori, I have been very busy and I didn't had time to answer and to fix this issue, I'll follow your advice to try to fix this. As you say I didn't change more than 1700 lines of code, in fact my changes are around 20 lines in the file addIssue.html

thank you again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants