Replace sample text for unicode-bidi example #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
requested review from
chrisdavidmills
and removed request for
a team
|
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
chrisdavidmills
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Hi @coolreader18! Thanks for this contribution to MDN. I really appreciate your thoughts here on respectful/appropriate use of language.
|
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the sample hebrew text used in the unicode-bidi example with a less meaningful line.
Motivation
The current text is a line from a Jewish prayer, and specifically a line that is usually said more quietly or to oneself - it startled me a bit to see it used as sample text. I replaced it with the first line from the Torah, "In the beginning God created the heavens and the earth", which is about as well-known as a bit of hebrew text can get.