Add notifications demos #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbamberg
requested review from
pepelsbey and
chrisdavidmills
and removed request for
a team and
pepelsbey
chrisdavidmills
approved these changes
Sep 23, 2025
There was a problem hiding this comment.
@wbamberg I think this is a really nice set of demos, which shows off the persistent/non-persistent concepts well. I don't have much here except for a few language suggestions, so I'm going to approve it.
|
@wbamberg another note — I pulled the PR down locally to test the demos, and they seem to work fine in Firefox and Chrome. |
Co-authored-by: Chris Mills <[email protected]>
|
Thank you Chris! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple of demos of the Notifications API, one showing persistent notifications, and one showing non-persistent notifications.
I wonder if it might be better to have the persistent one creating the notification in the SW, as well as managing it. That might be a more common use case, but it makes things a little more complicated...
Part of the fix for mdn/content#30931.