Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): add missing :modal pseudo-classes #862

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Dec 27, 2024

Description

per bcd, this feature has been supported by all platform

Motivation

Additional details

mdn web docs at https://developer.mozilla.org/en-US/docs/Web/CSS/:modal
spec at https://drafts.csswg.org/selectors/#selectordef-modal

Related issues and pull requests

can be part of the #241

@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 27, 2024 12:41
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 27, 2024 12:41
@skyclouds2001 skyclouds2001 requested review from bsmth and removed request for a team December 27, 2024 12:41
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, ty! 👍🏻

@bsmth bsmth merged commit 314b1ce into mdn:main Dec 30, 2024
3 checks passed
@skyclouds2001 skyclouds2001 deleted the modal branch December 30, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants