Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css): add missing anchor-size syntax for anchor-size() #861

Merged
merged 2 commits into from
Dec 30, 2024
Merged

feat(css): add missing anchor-size syntax for anchor-size() #861

merged 2 commits into from
Dec 30, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Dec 27, 2024 •
edited
Loading

Description

this is forgotten to add in #770

Motivation

CSS.supports('height','anchor-size(block)')
true
CSS.supports('height','anchor-size(inline)')
true
CSS.supports('height','anchor-size(height)')
true
CSS.supports('height','anchor-size(width)')
true
CSS.supports('height','anchor-size(self-block)')
true
CSS.supports('height','anchor-size(self-inline)')
true

Additional details

spec at https://drafts.csswg.org/css-anchor-position-1/#funcdef-anchor-size

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 27, 2024 12:32
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 27, 2024 12:32
@skyclouds2001 skyclouds2001 requested review from bsmth and removed request for a team December 27, 2024 12:32
bsmth
bsmth approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

@bsmth bsmth merged commit 37bf01a into mdn:main Dec 30, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
Open
@skyclouds2001 skyclouds2001 deleted the anchor-size branch December 30, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @bsmth