Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(css): Add obsolete value to status field for schema and docs #852

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

skyclouds2001
Copy link
Contributor

Description

this helps in preparing for #812

Motivation

Additional details

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 23, 2024 10:43
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 23, 2024 10:43
@skyclouds2001 skyclouds2001 requested review from bsmth and removed request for a team December 23, 2024 10:43
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That all makes sense to me, I'm adding a +1 for now, but it would be good to know if any consumers use a hardcoded status for anything (i.e., is this a breaking change for anything downstream?).

@skyclouds2001
Copy link
Contributor Author

skyclouds2001 commented Dec 30, 2024

I think it is OK currently for merging this PR, as this only make some additions by adding the obsolete field to those docs that does not have this field before (which means it is not used in the data yet), for consistent.

@bsmth
Copy link
Member

bsmth commented Dec 30, 2024

this only make some additions by adding the obsolete field

I agree, let's merge

@bsmth bsmth merged commit 9934f04 into mdn:main Dec 30, 2024
3 checks passed
@skyclouds2001 skyclouds2001 deleted the obsolete branch December 30, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants