Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Pages: SVGFESpotLightElement #37439

Merged
merged 7 commits into from
Jan 29, 2025
Merged

New Pages: SVGFESpotLightElement #37439

merged 7 commits into from
Jan 29, 2025

Conversation

yashrajbharti
Copy link
Contributor

part of Missing baseline pages project

@yashrajbharti yashrajbharti requested a review from a team as a code owner December 29, 2024 12:37
@yashrajbharti yashrajbharti requested review from sideshowbarker and removed request for a team December 29, 2024 12:37
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Dec 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 29, 2024 •
edited
Loading

Preview URLs (6 pages)

(comment last updated: 2025-01-29 00:06:49)

estelle
estelle reviewed Jan 29, 2025
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we add sub heading under examples, we should add an intro to what the example demonstrates. I made some suggestions that include a description of what the property controls hopefully making these examples even more useful

files/en-us/web/api/svgfespotlightelement/limitingconeangle/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svgfespotlightelement/pointsatx/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svgfespotlightelement/pointsaty/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svgfespotlightelement/pointsatz/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svgfespotlightelement/specularexponent/index.md Outdated Show resolved Hide resolved
@estelle estelle self-assigned this Jan 29, 2025
@yashrajbharti yashrajbharti requested a review from estelle January 29, 2025 00:06
@yashrajbharti
Copy link
Contributor Author

yashrajbharti commented Jan 29, 2025 •
edited
Loading

if we add sub heading under examples, we should add an intro to what the example demonstrates. I made some suggestions that include a description of what the property controls hopefully making these examples even more useful

Thanks, I will look for other PRs where a description needs to be added as well! ❤️

estelle
estelle approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit b73d366 into mdn:main Jan 29, 2025
8 checks passed
@yashrajbharti yashrajbharti deleted the feat/SVGFESpotLightElement branch January 29, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker sideshowbarker is a code owner automatically assigned from mdn/yari-content-web-api

Assignees

@estelle estelle

Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashrajbharti @estelle