Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDN Feature pages for SVGUseElement #37310

Merged
merged 8 commits into from
Jan 29, 2025
Merged

MDN Feature pages for SVGUseElement #37310

merged 8 commits into from
Jan 29, 2025
+270 −0

Conversation

yashrajbharti
Copy link
Contributor

part of Missing baseline pages project

@yashrajbharti yashrajbharti requested a review from a team as a code owner December 20, 2024 22:23
@yashrajbharti yashrajbharti requested review from wbamberg and removed request for a team December 20, 2024 22:23
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Dec 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2025-01-28 23:53:56)

estelle
estelle reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use console.dir for objects (i.e. x.baseVal => {SVGLength
unitType: 2,
value: 50,
valueAsString: "25%",
valueInSpecifiedUnits: 25}) and console.log for values (x.baseVal.value => 50, or x.baseVal.unitType => 2),

files/en-us/web/api/svguseelement/y/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svguseelement/y/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svguseelement/x/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svguseelement/width/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/svguseelement/height/index.md Outdated Show resolved Hide resolved
@yashrajbharti yashrajbharti requested a review from estelle January 28, 2025 23:55
@estelle estelle self-assigned this Jan 29, 2025
estelle
estelle approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yippee! 🎉

@estelle estelle merged commit 6fbc4d2 into mdn:main Jan 29, 2025
8 checks passed
@yashrajbharti yashrajbharti deleted the feat/SVGUseElement branch January 29, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

Assignees

@estelle estelle

Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yashrajbharti @estelle