Improve startViewTransition() data #28541
+79
−9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -8380,10 +8380,10 @@ | |||||||||||||
| "deprecated": false | ||||||||||||||
| } | ||||||||||||||
| }, | ||||||||||||||
| "options_parameter": { | ||||||||||||||
| "__compat": { | ||||||||||||||
| "description": "`options` parameter", | ||||||||||||||
| "spec_url": "https://drafts.csswg.org/css-view-transitions-2/#dictdef-startviewtransitionoptions", | ||||||||||||||
| "tags": [ | ||||||||||||||
| "web-features:view-transitions" | ||||||||||||||
| ], | ||||||||||||||
|
|
@@ -8414,12 +8414,84 @@ | |||||||||||||
| "standard_track": true, | ||||||||||||||
| "deprecated": false | ||||||||||||||
| } | ||||||||||||||
| }, | ||||||||||||||
| "types_property": { | ||||||||||||||
| "__compat": { | ||||||||||||||
| "description": "`types` property", | ||||||||||||||
| "spec_url": "https://drafts.csswg.org/css-view-transitions-2/#dom-startviewtransitionoptions-types", | ||||||||||||||
| "tags": [ | ||||||||||||||
| "web-features:view-transitions" | ||||||||||||||
| ], | ||||||||||||||
| "support": { | ||||||||||||||
| "chrome": { | ||||||||||||||
| "version_added": "125" | ||||||||||||||
| }, | ||||||||||||||
| "chrome_android": "mirror", | ||||||||||||||
| "edge": "mirror", | ||||||||||||||
| "firefox": { | ||||||||||||||
| "version_added": false, | ||||||||||||||
| "impl_url": "https://bugzil.la/1860854" | ||||||||||||||
| }, | ||||||||||||||
| "firefox_android": "mirror", | ||||||||||||||
| "oculus": "mirror", | ||||||||||||||
| "opera": "mirror", | ||||||||||||||
| "opera_android": "mirror", | ||||||||||||||
| "safari": { | ||||||||||||||
| "version_added": "18.2" | ||||||||||||||
| }, | ||||||||||||||
| "safari_ios": "mirror", | ||||||||||||||
| "samsunginternet_android": "mirror", | ||||||||||||||
| "webview_android": "mirror", | ||||||||||||||
| "webview_ios": "mirror" | ||||||||||||||
| }, | ||||||||||||||
| "status": { | ||||||||||||||
| "experimental": false, | ||||||||||||||
| "standard_track": true, | ||||||||||||||
| "deprecated": false | ||||||||||||||
| } | ||||||||||||||
| } | ||||||||||||||
| }, | ||||||||||||||
| "update_property": { | ||||||||||||||
| "__compat": { | ||||||||||||||
| "description": "`update` property", | ||||||||||||||
|
Comment on lines
+8452
to
+8454
Contributor
There was a problem hiding this comment.
Suggested change
Edit: Updated following #28541 (comment). |
||||||||||||||
| "spec_url": "https://drafts.csswg.org/css-view-transitions-2/#dom-startviewtransitionoptions-update", | ||||||||||||||
| "tags": [ | ||||||||||||||
| "web-features:view-transitions" | ||||||||||||||
| ], | ||||||||||||||
| "support": { | ||||||||||||||
| "chrome": { | ||||||||||||||
| "version_added": "125" | ||||||||||||||
| }, | ||||||||||||||
| "chrome_android": "mirror", | ||||||||||||||
| "edge": "mirror", | ||||||||||||||
| "firefox": { | ||||||||||||||
| "version_added": false, | ||||||||||||||
| "impl_url": "https://bugzil.la/1860854" | ||||||||||||||
| }, | ||||||||||||||
| "firefox_android": "mirror", | ||||||||||||||
| "oculus": "mirror", | ||||||||||||||
| "opera": "mirror", | ||||||||||||||
| "opera_android": "mirror", | ||||||||||||||
| "safari": { | ||||||||||||||
| "version_added": "18.2" | ||||||||||||||
| }, | ||||||||||||||
| "safari_ios": "mirror", | ||||||||||||||
| "samsunginternet_android": "mirror", | ||||||||||||||
| "webview_android": "mirror", | ||||||||||||||
| "webview_ios": "mirror" | ||||||||||||||
| }, | ||||||||||||||
| "status": { | ||||||||||||||
| "experimental": false, | ||||||||||||||
| "standard_track": true, | ||||||||||||||
| "deprecated": false | ||||||||||||||
| } | ||||||||||||||
| } | ||||||||||||||
| } | ||||||||||||||
| }, | ||||||||||||||
| "updateCallback_parameter": { | ||||||||||||||
| "__compat": { | ||||||||||||||
| "description": "`updateCallback` parameter", | ||||||||||||||
| "spec_url": "https://drafts.csswg.org/css-view-transitions-2/#callbackdef-viewtransitionupdatecallback", | ||||||||||||||
| "tags": [ | ||||||||||||||
| "web-features:view-transitions" | ||||||||||||||
| ], | ||||||||||||||
|
|
||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BCD guidelines suggest to not nest these:
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @ddbeck Is this a special case warranting an exception? (I don't remember understanding why we don't nest these.)
Edit: Nesting has the benefit of linting the child support data against the parent support data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, not nesting them seems a little odd to me.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I think the reason we had that guideline was that deeply-nested keys didn't get rendered on compat tables because of recursion limit on MDN. I'm not sure what the limit is today or if it still matters.
I agree that having the linting on nested data is a real gain. I'm fine with deviating from the guideline for this PR. And we ought to consider formally revising the existing guideline. @caugner would you mind putting it on the agenda for the first BCD call in January?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nowadays, the BCD table hides nested features only there would be too many features otherwise: https://github.com/mdn/fred/blob/7d1da1e38e4394f5fd04b4d8c5c90073ee4b0134/components/compat-table/element.js#L345-L348
So I agree with deviating from the guideline for this PR, and discuss updating it in January.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said, I think the description should still reflect the full path (and use the term "parameter", not "property"):