Revert "Update Safari data for aspect-ratio CSS property" #20031
Conversation
This reverts commit b203d53.
github-actions
bot
added
the
data:css
|
In #19570, I think the only evidence for the change is https://mdn-bcd-collector.gooborg.com/tests/css/properties/aspect-ratio, and I couldn't confirm any effect of |
|
This was probably caused by the bug where |
|
Ah, that would make sense! Would you happen to know how far back that bug goes, and is there a way to list flags? I suspect there are more errors in BCD due to this... |
|
I'm unable to verify that this property does anything to images in Safari 14.1, though I could have sworn I had tested for support before... |
queengooborg
deleted the
revert-19570-css/properties/aspect-ratio/safari-corrections
branch
Goes back to CSS.supports's introduction, I'm pretty sure, and seems to have been fixed in Safari 15. And then there's also foolip/mdn-bcd-collector#1955. |
This was actually probably already fixed by openwebdocs/mdn-bcd-collector@7eff721! |
|
It might be worthwhile using that code branch for Safari < 15, dunno. |
Oh it's already been in use; that branch is the main deployment of the collector at https://mdn-bcd-collector.gooborg.com! I've also modified the test in openwebdocs/mdn-bcd-collector@55ba62d to pass an applicable value (instead of just |
|
Did openwebdocs/mdn-bcd-collector@55ba62d cause any changes? I don't think it should for Safari? Maybe it does. The better fix would just be what I meant above—not using the |
It did, yes -- it reports |
Reverts #19570