Convert RecSup function possible exceptions to dbAccess error codes #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdavidsaver
reviewed
Aug 18, 2021
| errlogPrintf("dbExceptionToLong: Unhandled exception\n"); | ||
| /* Return something more meaningful? */ | ||
| return S_db_errArg; | ||
| } |
There was a problem hiding this comment.
I don't think there is much value in translating specific exceptions.
It might be more useful to print the specific exception type typeid(e).name() along with e.what().
There was a problem hiding this comment.
Ok. Is S_db_errArg a good error for this general "unhandled exception" case?
|
|
||
| /* | ||
| * Wraps all RecordSupport functions from throwable functions to no-throwable ones, | ||
| * without using C++11 features |
There was a problem hiding this comment.
Well, this does give a good example of why I didn't do this initially. For the moment, let's only add wrappers as they used.
modules/database/src/ioc/db/Makefile
Outdated
|
|
||
| INC += callback.h | ||
| INC += dbAccess.h | ||
| INC += dbAccessNoThrow.h |
There was a problem hiding this comment.
This header should not be installed (aka. become a supported public API).
New record support functions, especially when using DBR_VFIELD, might throw exceptions that would not be handled in C code, leading to undefined behavior. This patch attempts to safely convert exceptions into error codes so dbAccess might act upon them correctly.
|
❌ Build epics-base base-vfield-750 failed (commit c6c4c24535 by @lerwys) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the right approach, but it's a first working take, at least.