Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty config files #41

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Handle empty config files #41

merged 3 commits into from
Oct 16, 2024

Conversation

frenzymadness
Copy link
Collaborator

Fixes: #40

@hroncok
Copy link
Contributor

hroncok commented Oct 15, 2024

I don't like this behavior.

If you have a config file in your PWD and it has a typo, it is silently skipped and another (lower priority) config file is used instead.

This goes against Errors should never pass silently.

If an invalid config file is found, please error immediately.

@frenzymadness
Copy link
Collaborator Author

Fixed

hroncok
hroncok reviewed Oct 15, 2024
View reviewed changes
@frenzymadness
Copy link
Collaborator Author

Done.

@frenzymadness
Copy link
Collaborator Author

@mcurlej wanna take a look?

@mcurlej
Copy link
Owner

mcurlej commented Oct 16, 2024

+1

@mcurlej mcurlej merged commit 33e2753 into mcurlej:main Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hroncok hroncok hroncok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config file validation
3 participants
@frenzymadness @hroncok @mcurlej