Enable debug logging only if JOFT_DEBUG env var is defined #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, can you add this option as a part of the documentation? like just a quick section about logging and how to set up the log level with the global var. Thanks! |
|
I don't see an existing section in the docs that would fit. Is a sentence in readme enough? |
|
Sure |
frenzymadness
force-pushed
the
debug_logging
branch
from
0fdb797 to
9febde9
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running multiple templates in a loop, the amount of logs printed out is kinda annoying. This makes the default logging level higher with an easy way to enable debug back.