boot: zephyr: config: Allow custom MCUBOOT_BOOT_MAX_ALIGN #2453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow setting CONFIG_MCUBOOT_BOOT_MAX_ALIGN to apply a custom programmable block in flash. Signed-off-by: Pieter De Gendt <[email protected]>
de-nordic
reviewed
Sep 25, 2025
Comment on lines
+433
to
+435
| #if defined(CONFIG_MCUBOOT_BOOT_MAX_ALIGN) && CONFIG_MCUBOOT_BOOT_MAX_ALIGN > 0 | ||
| #define MCUBOOT_BOOT_MAX_ALIGN CONFIG_MCUBOOT_BOOT_MAX_ALIGN | ||
| #elif DT_HAS_CHOSEN(zephyr_flash) |
There was a problem hiding this comment.
We have these dt_ macros to use with Kconfig, can we maybe move the entire logic to Kconfig?
There was a problem hiding this comment.
Probably, yes but this fix should make that backwards compatible, no?
There was a problem hiding this comment.
Yeah. So you set the Kconfig to defaults as the logic states here, but people can still override it. Wouldn't that make it backwards compatible?
There was a problem hiding this comment.
This way we also have only one place where it is set: the Kconfig; there would no "if Kconfig is 0 then", because it could only be 0 if we allow somebody to set it as such in Kconfig.
There was a problem hiding this comment.
Am I missing something here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting CONFIG_MCUBOOT_BOOT_MAX_ALIGN to apply a custom programmable block in flash.