boot: zephyr: Refactor USB DFU entry logic #2277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing with the following logs: What shall I do to make it clone? |
FIH hardening tests can be ignored, these are failing due to a problem with the TFM git server |
de-nordic
reviewed
Apr 25, 2025
sayooj-aerlync
force-pushed
the
usb.dfu.optimization
branch
from
54b47cb to
8000f2f
Compare
de-nordic
reviewed
Apr 25, 2025
de-nordic
reviewed
Apr 25, 2025
sayooj-aerlync
force-pushed
the
usb.dfu.optimization
branch
from
8000f2f to
a77c554
Compare
|
Please have a look into this @de-nordic @nordicjm |
|
Will look at it after the current 2.2.0 release concludes, currently bug fixes only |
|
Could you please check this? |
nordicjm
reviewed
Jun 17, 2025
sayooj-aerlync
force-pushed
the
usb.dfu.optimization
branch
from
a77c554 to
0ca65eb
Compare
nordicjm
approved these changes
Jun 17, 2025
|
I think the build failure is not related to this change: |
|
can you rebase your branch on main? Should fix CI |
Consolidates USB DFU entry logic by unifying GPIO and timeout-based DFU triggers under a common flag. This avoids code duplication and improves maintainability. Also improves log clarity for different DFU exit conditions. Signed-off-by: Sayooj K Karun <[email protected]>
sayooj-aerlync
force-pushed
the
usb.dfu.optimization
branch
from
5432acb to
ab2d7bc
Compare
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates USB DFU entry logic by unifying GPIO and timeout-based DFU triggers under a common flag. This avoids code duplication and improves maintainability.
Also improves log clarity for different DFU exit conditions.