boot: zephyr: kconfig: Default to swap using offset for nRF devices #2266
Conversation
Defaults to the new swap using offset mode Signed-off-by: Jamie McCrae <[email protected]>
Fixes an issue with swap using offser with serial recovery by changing an #ifdef Signed-off-by: Jamie McCrae <[email protected]>
| @@ -397,14 +397,14 @@ config BOOT_VALIDATE_SLOT0_ONCE | |||
|
|
|||
| config BOOT_PREFER_SWAP_OFFSET | |||
| bool "Prefer the newer swap offset algorithm" | |||
| default y if SOC_FAMILY_NORDIC_NRF | |||
There was a problem hiding this comment.
Can we make it default for all platforms?
By adding: default y if !$(dt_nodelabel_enabled,scratch_partition)
There was a problem hiding this comment.
It's not been made the default for all platforms due to the sector size requirements, if a device has equal sizes for slot 0 and slot 1 then it will work (but is not ideal) but if it has the swap using move ideal setup of slot 0 being larger than slot 1, it will fail, so has been left as swap using move for default for now
There was a problem hiding this comment.
if a device has equal sizes for slot 0 and slot 1 then it will work (but is not ideal)
Using optimized slot sizes is broken with the latest mcuboot: zephyrproject-rtos/zephyr#88850
It seems, I need to switch to equal slot sizes (at least for NXP) to make it work for all modes, even if it's not optimal.
There was a problem hiding this comment.
That has been fixed efa3039 but has not been pulled into zephyr yet
There was a problem hiding this comment.
That has been fixed efa3039 but has not been pulled into zephyr yet
Great! Thank you.
Defaults to the new swap using offset mode