Add checks to crypto operation calls in MCUboot #2263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karambite <[email protected]>
de-nordic
reviewed
Apr 16, 2025
Comment on lines
+97
to
+105
| if (bootutil_sha_update(&ctx, hash, PSS_HLEN)) { | ||
| goto out; | ||
| } | ||
| if (bootutil_sha_update(&ctx, counter, 4)) { | ||
| goto out; | ||
| } | ||
| if(bootutil_sha_finish(&ctx, htmp)){ | ||
| goto out; | ||
| } |
There was a problem hiding this comment.
No reason to do so? What is the point, fail quicker?
There was a problem hiding this comment.
Yes. If the any of the sha operation fails, then why should it even attempt the rest? It stays consistent with other crypto implementations.
There was a problem hiding this comment.
I see no reason. If it fails it fails. There is no info here for reason nor any way to recover. But the code gets increased for adding condition checks and jumps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.