pf2e v14 bug fix#337
Closed
Saibot393 wants to merge 1 commit into
Closed
Conversation
Owner
|
Thank you for your contribution, but I'll close this in favor of 1e953bc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the newest versions of pf2e (post v14 compatibility),
CONFIG.statusEffectsno longer returns an array but instead an object. This causesCONFIG.statusEffects.findto fail in 4 separate instances and Health Estimate to stop working for pf2e.I replaced all instances of
CONFIG.statusEffectswith(Array.isArray(CONFIG.statusEffects) ? CONFIG.statusEffects : Object.values(CONFIG.statusEffects)), making sure that we always have a workable array. Note, that the object entries appear to follow the same scheme as before the update, i.e. things likeidandimgare still present.This is the easiest to solution i can think of to fix this problem for pf2e without risking compatibility with any other system. It might also fix other system compatibility issues down the line