Skip to content

Conversation

@g5t
Copy link
Collaborator

@g5t g5t commented Dec 24, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the config_set and config_unset command-line tools to persist changes to the configuration file on disk, fixing a previous deficiency where these commands only modified in-memory configuration. The implementation adds helper functions to read and write YAML configuration files and includes comprehensive test coverage.

Key Changes:

  • Added _get_config_yaml() and _save_config_yaml() helper functions to read and write configuration files
  • Modified config_set() and config_unset() to accept an optional path parameter and persist changes to disk
  • Added pyyaml dependency and Python 3.14 classifier to pyproject.toml

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/mccode_antlr/cli/management.py Core implementation changes: added helper functions for YAML file I/O, modified config_set/config_unset to persist changes to disk, updated argument parsers to accept path parameter
tests/test_nested_key_issue.py New test file to verify nested key preservation when setting configuration values
tests/test_config_unset_issue.py New test file to verify key deletion while preserving other configuration keys
tests/test_cli_management.py Comprehensive pytest test suite covering config and cache management functionality
pyproject.toml Added pyyaml dependency and Python 3.14 classifier

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@g5t g5t linked an issue Dec 24, 2025 that may be closed by this pull request
@g5t g5t merged commit bf76294 into main Dec 24, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mccode-antlr config is not fully functioning

2 participants