Cleaned up PAPI Expansion #4906
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nossr50
requested changes
Jun 20, 2023
| if (user == null) return null; | ||
|
|
||
| if (params.startsWith("level_")) { | ||
| PrimarySkillType skill = PrimarySkillType.valueOf(params.substring(6).toUpperCase()); |
There was a problem hiding this comment.
you could make use of constants to avoid these hard coded magic numbers
public static final String SKILL_LEVEL = "level_";
// later on
PrimarySkillType skill = PrimarySkillType.valueOf(params.substring(SKILL_LEVEL.length()).toUpperCase());
There was a problem hiding this comment.
Would you like this done for those only needing substring or all?
Eg. "in_party"
| if (params.startsWith("level_")) { | ||
| PrimarySkillType skill = PrimarySkillType.valueOf(params.substring(6).toUpperCase()); | ||
| return skill == null ? null : user.getSkillLevel(skill)+""; | ||
| }else if (params.startsWith("xp_needed_")) { |
| return skill == null ? null : (user.getXpToLevel(skill) - user.getSkillXpLevel(skill))+""; | ||
| }else if (params.startsWith("xp_")) { | ||
| PrimarySkillType skill = PrimarySkillType.valueOf(params.substring(3).toUpperCase()); | ||
| return skill == null ? null : user.getSkillXpLevel(skill)+""; |
There was a problem hiding this comment.
Would prefer String.valueOf() but this is perhaps a small nitpick
|
Should be all tidied up now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up PAPI Expansion, narrowing it down to only 1 class