chore: Add text to S3 object metadata #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaddox5
changed the title
digitalcora
reviewed
Aug 27, 2024
| ExAws.S3.put_object_copy(bucket, key, bucket, key, metadata_directive: :REPLACE) | ||
| ExAws.S3.put_object_copy(bucket, key, bucket, key, | ||
| metadata_directive: :REPLACE, | ||
| meta: [{:text, text}] |
There was a problem hiding this comment.
What was the reason we're replacing the metadata with this copy? Is that needed to update the timestamp? It doesn't appear to be part of what S3 terms "metadata" — my admittedly brief searching suggests it's almost impossible to not update the timestamp when writing an object, regardless of the method.
There was a problem hiding this comment.
I think that without directive, the call would error out because it was a no-op. Telling it to replace the metadata makes it an actual change, so it completes and updates the timestamp, which is what we actually care about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added text sent to Polly to the S3 object metadata:
