fix: Activation not updating channel bug #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfauble
approved these changes
Feb 14, 2025
hannahpurcell
changed the base branch from
hp/populate-detours-list-with-channels
to
main
hannahpurcell
force-pushed
the
hp/activation-not-updating-channel-bug
branch
from
a88f81a to
0e9f1d4
Compare
hannahpurcell
force-pushed
the
hp/activation-not-updating-channel-bug
branch
from
0e9f1d4 to
79eec20
Compare
bfauble
pushed a commit
that referenced
this pull request
Feb 27, 2025
* fix: add function for detours without virtual estimated_duration population
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this when working on using the detours channel on the detours list. Drafted detours appeared in the channel immediately; deactivated detours correctly moved from the activated to deactivated channel immediately; but drafted detours getting activated didn't get put into the activated channel. It seems that drafted detours for which the activation had just been applied only had a reference to the
selectedDurationin their state and not in their virtual DB field.Is this something that should be changed in the DB side, or is adding a new function match correct at this stage?