feat: delete draft detour backend #2925
Conversation
…into bf-delete-draft-detour
…t to pubsub for frontend to update list of draft detours on deletion.
| @@ -556,6 +557,23 @@ export const fetchDetour = ( | |||
| ErrStruct: never(), | |||
| }).then((v) => map(v, detourStateFromData)) | |||
|
|
|||
| export const deleteDetour = ( | |||
| id: number | undefined | |||
There was a problem hiding this comment.
question: when would id be undefined?
There was a problem hiding this comment.
good catch, shouldn't be anymore. the guard for an id already existing is now further up the tree and this typecheck shouldn't be necessary
| const detourPanel: ({ | ||
| deleteDetourCallback, | ||
| }: { | ||
| deleteDetourCallback: () => void | ||
| }) => React.JSX.Element = () => { |
There was a problem hiding this comment.
question: What's the benefit of getting this via a parameter instead of pulling it from the scope?
There was a problem hiding this comment.
deleteDetourCallback is also making use of the onClose callback being passed into the DiversionPage props, so either way props would be passed into detourPanel but for me it makes sense to have these callbacks/hooks/memos/etc be defined above the rendering of the overall component vs constructing the callback logic at the very last second.
| @@ -170,6 +179,13 @@ export const useDraftDetours = (socket: Socket | undefined) => { | |||
| }) | |||
| } | |||
|
|
|||
| const handleDeleted = (detour_id: number) => { | |||
There was a problem hiding this comment.
nit: as much as I love snake_case, we should be using camelCase for variables on the TS side. (if we were more flexible about this, I'd get rid of all our "-Data" structs 😭 )
I'm honestly baffled we don't have a lint for this.
There was a problem hiding this comment.
These changes don't quite make sense to me, and part of that is on me for not seeing this in #2909
As is, when the detour.delete.delete-modal.delete-draft event is sent, the state machine will go through the following states
"Detour Drawing"."Share Detour"."Deleting"."Confirming"[Start state]"Detour Drawing"."Share Detour"."Deleting"."Deleted""Detour Drawing"."Share Detour"."Deleting"."Done""Detour Drawing"."Share Detour"."DoneNoSave""Detour Drawing"."Active"
There was a problem hiding this comment.
Oh oops this posted before I meant it to.
There was a problem hiding this comment.
I think you might want something like this instead
Deleting: {
on: {
"detour.delete.delete-modal.cancel": {
target: "Reviewing",
},
"detour.delete.delete-modal.delete-draft": {
tags: "no-save",
target: "Deleted"
}
},
},
Deleted: { tags: "no-save" },
There was a problem hiding this comment.
I actually meant to ask the best way to approach this "ending" of this workflow. The problem was popping up where the snapshot was attempting to be auto-saved immediately after the delete step. I'll have to work through the steps that actually are fired again, but I think the 'correct' end should be....
Deleted: {
tags: "no-save",
type: "final"
}
and remove the onDone and DoneNoSave
There was a problem hiding this comment.
x-posting/summarizing from slack: it may be better to setup a top level state that halt's the machine and use an id to go to that state from the nested state.
Asana Ticket: https://app.asana.com/0/1205385723132845/1208845212421698/f