wip! remove state_value vfield

mbta · Feb 18, 2025 · 4cc8760 · 4cc8760
1 parent fc505f9
commit 4cc8760
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 13 deletions.
diff --git a/lib/skate/detours/db/detour.ex b/lib/skate/detours/db/detour.ex
@@ -39,10 +39,6 @@ defmodule Skate.Detours.Db.Detour do
     # Activated properties
     field :estimated_duration, :string, virtual: true
 
-    # Temporary field to make querying the `:state` faster and avoid needing to
-    # pull the entire `:state` value
-    field :state_value, :map, virtual: true
-
     # -------------------------------------------------------
   end
 
@@ -126,7 +122,6 @@ defmodule Skate.Detours.Db.Detour do
           :direction -> select_direction(query)
           :nearest_intersection -> select_starting_intersection(query)
           :estimated_duration -> select_estimated_duration(query)
-          :state_value -> select_state_value(query, :state_value)
           _unknown -> query
         end
       end)
@@ -248,9 +243,5 @@ defmodule Skate.Detours.Db.Detour do
         ^key => d.state["context"]["selectedDuration"]
       })
     end
-
-    def select_state_value(query \\ base(), key \\ :state_value) do
-      select_merge(query, [detour: d], %{^key => %{"value" => d.state["value"]}})
-    end
   end
 end
diff --git a/lib/skate/detours/detours.ex b/lib/skate/detours/detours.ex
@@ -120,10 +120,6 @@ defmodule Skate.Detours.Detours do
   user
   """
   @spec categorize_detour(detour :: map()) :: Detour.status()
-  def categorize_detour(%{state_value: state_value}) when not is_nil(state_value) do
-    categorize_detour(%{state: state_value})
-  end
-
   def categorize_detour(%{state: %{"value" => %{"Detour Drawing" => %{"Active" => _}}}}),
     do: :active