tweak: The detours dropdown should totally be behind DetoursOnLadder …

…flag
mbta · Feb 14, 2025 · 31c77c6 · 31c77c6
1 parent b8b3f65
commit 31c77c6
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 17 deletions.
diff --git a/assets/src/components/routeLadder.tsx b/assets/src/components/routeLadder.tsx
@@ -83,7 +83,7 @@ export const Header = ({
             hasAlert && "c-route-ladder__dropdown--non-skate-alert",
           ])}
         >
-          {isAdmin && (
+          {(isAdmin || inTestGroup(TestGroups.DetoursOnLadder)) && (
             <Dropdown className="border-box inherit-box">
               <Dropdown.Toggle
                 className="c-route-ladder__dropdown-button d-flex"
@@ -116,7 +116,7 @@ export const Header = ({
                 )}
                 {hasAlert && (
                   <>
-                    <Dropdown.Divider className="border-top-0" />
+                    {isAdmin && <Dropdown.Divider className="border-top-0" />}
                     <Dropdown.Header>
                       <div className="c-route-ladder__dropdown-header-text">
                         Active detours
@@ -148,11 +148,11 @@ export const Header = ({
                     )}
                   </>
                 )}
-                {/* {!hasAlert && (
-                <Dropdown.ItemText className="lh-base pb-4">
-                  No active detours
-                </Dropdown.ItemText>
-              )} */}
+                {!hasAlert && inTestGroup(TestGroups.DetoursOnLadder) && (
+                  <Dropdown.ItemText className="lh-base pb-4">
+                    No active detours
+                  </Dropdown.ItemText>
+                )}
               </Dropdown.Menu>
             </Dropdown>
           )}

diff --git a/assets/tests/components/__snapshots__/routeLadder.test.tsx.snap b/assets/tests/components/__snapshots__/routeLadder.test.tsx.snap
@@ -13,7 +13,7 @@ exports[`routeLadder displays loading if we are fetching the timepoints 1`] = `
       />
       <div
         class="c-route-pill c-route-pill--bus c-route-pill--large-format c-route-pill--dynamic-size"
-        id="route-pill:ru:"
+        id="route-pill:r11:"
       >
         28
       </div>
@@ -59,7 +59,7 @@ exports[`routeLadder displays no crowding data for a bus coming off a route with
       />
       <div
         class="c-route-pill c-route-pill--bus c-route-pill--large-format c-route-pill--dynamic-size"
-        id="route-pill:rq:"
+        id="route-pill:rt:"
       >
         28
       </div>
@@ -328,7 +328,7 @@ exports[`routeLadder doesn't display crowding data for a vehicle coming off a ro
       />
       <div
         class="c-route-pill c-route-pill--bus c-route-pill--large-format c-route-pill--dynamic-size"
-        id="route-pill:rs:"
+        id="route-pill:rv:"
       >
         28
       </div>
@@ -540,7 +540,7 @@ exports[`routeLadder doesn't render a bus that's off-course but nonrevenue 1`] =
       />
       <div
         class="c-route-pill c-route-pill--bus c-route-pill--large-format c-route-pill--dynamic-size"
-        id="route-pill:ro:"
+        id="route-pill:rr:"
       >
         28
       </div>
@@ -856,7 +856,7 @@ exports[`routeLadder renders a route ladder with crowding instead of vehicles 1`
       />
       <div
         class="c-route-pill c-route-pill--bus c-route-pill--large-format c-route-pill--dynamic-size"
-        id="route-pill:rm:"
+        id="route-pill:rp:"
       >
         28
       </div>
@@ -1129,7 +1129,7 @@ exports[`routeLadder renders a route ladder with laying over vehicles 1`] = `
       />
       <div
         class="c-route-pill c-route-pill--bus c-route-pill--large-format c-route-pill--dynamic-size"
-        id="route-pill:rk:"
+        id="route-pill:rn:"
       >
         28
       </div>
@@ -1647,7 +1647,7 @@ exports[`routeLadder renders a route ladder with vehicles 1`] = `
       />
       <div
         class="c-route-pill c-route-pill--bus c-route-pill--large-format c-route-pill--dynamic-size"
-        id="route-pill:rg:"
+        id="route-pill:rj:"
       >
         28
       </div>
@@ -1951,7 +1951,7 @@ exports[`routeLadder renders a route ladder with vehicles in the incoming box 1`
       />
       <div
         class="c-route-pill c-route-pill--bus c-route-pill--large-format c-route-pill--dynamic-size"
-        id="route-pill:ri:"
+        id="route-pill:rl:"
       >
         28
       </div>

diff --git a/assets/tests/components/routeLadder.test.tsx b/assets/tests/components/routeLadder.test.tsx
@@ -367,8 +367,9 @@ describe("routeLadder", () => {
     expect(screen.getByText("Add detour")).toBeVisible()
   })
 
-  // eslint-disable-next-line jest/no-disabled-tests
-  test.skip("does not render 'Add detour' in the dropdown if not an admin", async () => {
+  test("does not render 'Add detour' in the dropdown if not an admin", async () => {
+    jest.mocked(getTestGroups).mockReturnValue([TestGroups.DetoursOnLadder])
+
     const route: Route = routeFactory.build({
       id: "28",
       name: "28",