Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused/broken BlueBikes widget #2383

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

digitalcora
Copy link
Contributor

This feature has been unused since the original Orange Line "surge" it was developed for in mid-2022, and non-working since July 2023, when the data fetching was commented out due to persistent crashes (see 9211202).

We should avoid leaving code committed that will never be executed and/or features available in the admin UI that don't work. Should we choose to prioritize this feature again, the old code lives on in the history of the repo for reference.

@digitalcora digitalcora marked this pull request as ready for review January 6, 2025 22:08
@digitalcora digitalcora requested a review from a team as a code owner January 6, 2025 22:08
@robbie-sundstrom
Copy link
Contributor

Everything that's deleted here makes sense!

Looking through the code for anything else related to clean up, I found one a reference to a bike_issue for alerts. I don't believe that's related, but also haven't been able to figure out what it's actually for. Do you know if that's needed?

@digitalcora
Copy link
Contributor Author

bike_issue is a possible effect type for alerts (alerts have "effect" and "cause" enums which are sort of like "what's happening" and "why is it happening" respectively). For completeness we have all the known cause/effect types in our alert parsing even if we don't do anything specific with them. So this is all unrelated to BlueBikes service — an alert with an effect of bike_issue might be used if an MBTA-owned bike cage at a station was inaccessible, for example.

@robbie-sundstrom
Copy link
Contributor

gotcha, having all alert types, even ones we don't use explains it! I see other alert types that aren't used either now

Copy link
Contributor

@robbie-sundstrom robbie-sundstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaning up old code like the hero our team needs 🦸‍♀️

This feature has been unused since the original Orange Line "surge" it
was developed for in mid-2022, and non-working since July 2023, when the
data fetching was commented out due to persistent crashes (see 9211202).

We should avoid leaving code committed that will never be executed
and/or features available in the admin UI that don't work. Should we
choose to prioritize this feature again, the old code lives on in the
history of the repo for reference.
@digitalcora digitalcora force-pushed the cfg-bikeless-in-boston branch from 1ded909 to 2b1981d Compare January 7, 2025 15:13
@digitalcora digitalcora merged commit f661bb2 into main Jan 7, 2025
12 checks passed
@digitalcora digitalcora deleted the cfg-bikeless-in-boston branch January 7, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants