Use "Southbound" for Red Line non revenue trains #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panentheos
reviewed
Jan 16, 2025
lib/content/audio/passthrough.ex
Outdated
| if audio.destination in [:ashmont, :braintree], | ||
| do: PaEss.Utilities.train_description(:southbound, audio.route_id), | ||
| else: PaEss.Utilities.train_description(audio.destination, audio.route_id) | ||
|
|
There was a problem hiding this comment.
There's a bit of logic in Signs.Utilities.Predictions.prediction_passthrough_audios that does some munging of the destination, which should be updated. Actually, that might be a more natural place to override the destination to :southbound, and then this module could directly map that.
|
@panentheos I checked in with Shanti and she'd like us to put this into production on 1/28 to align with a meeting that she's going to have with the OCC to fill them in on this. Can we plan for that? |
panentheos
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: Use "Southbound" instead of Ashmont/Braintree for non-revenue trains
Adds take
891which announces Ashmont and Braintree Red Line passthroughs as "Southbound". Also adjusts the TTS codepaths to do the same.Reviewer Checklist
signs.jsonwas changed, there is a follow-up PR tosigns_uito update its dependency on this project