unify prediction audios #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulJKim
reviewed
Jan 14, 2025
lib/content/audio/predictions.ex
Outdated
Comment on lines
6
to
24
| [ | ||
| %__MODULE__{ | ||
| prediction: message.prediction, | ||
| special_sign: message.special_sign, | ||
| terminal?: message.terminal?, | ||
| next_or_following: next_or_following | ||
| } | ||
| ] | ||
| end | ||
|
|
||
| def from_message(%Content.Message.StoppedTrain{} = message, next_or_following) do | ||
| [ | ||
| %__MODULE__{ | ||
| prediction: message.prediction, | ||
| special_sign: message.special_sign, | ||
| terminal?: message.terminal?, | ||
| next_or_following: next_or_following | ||
| } | ||
| ] |
There was a problem hiding this comment.
Since these two clauses are doing the same thing, is it worth separating the struct instantiation into a helper?
lib/content/audio/predictions.ex
Outdated
|
|
||
| cond do | ||
| !platform -> {nil, false, nil} | ||
| jfk_mezzanine? and minutes > 9 -> {nil, false, :later} |
There was a problem hiding this comment.
With documentation/posterity (although I think the typespec mostly covers that) and avoiding "magic numbers" in code in mind, it might be worthwhile if we swap out 9 and 5 for some module attributes. @announce_platform_later_threshold and @announce_platform_soon_threshold or something along those lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This combines the
NextTrainCountdown,FollowingTrain, andStoppedTrainaudio modules into one unified module. The goal is to reduce some overlapping logic between these code paths, and pave the way for future refactoring.This includes a slight wording change on JFK platforms readouts, which was ok'd by product and is illustrated with a new test case. The other test deltas are minor capitalization and punctuation changes to TTS strings resulting from standardizing the code, which shouldn't substantially affect the output.