aggregate PA message playback #869
Merged
+73
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulJKim
reviewed
Jan 13, 2025
Comment on lines
+67
to
+71
| for sign_id <- message.sign_ids, | ||
| {sign, should_play?} = GenServer.call(:"Signs/#{sign_id}", {:play_pa_message, message}), | ||
| should_play? do | ||
| sign | ||
| end |
There was a problem hiding this comment.
Any thoughts on calling out to all the sign processes concurrently using Task?
There was a problem hiding this comment.
I think using Task would be overkill here, since this call should complete more or less instantly.
PaulJKim
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: Revise RTS to remove PA Message bottleneck failures in Legacy PA/ESS
This changes the playback code for PA messages to send a single aggregate message to all targeted zones within a station, instead of individual per-sign messages. This involves moving the responsibility for playback into the PA message engine, and having the signs just provide their configs (and continue to track playbacks in order to guard against accidental duplicates).