feat(clinical): add deterministic summary length budgets - #3173
Open
maziyarpanahi wants to merge 1 commit into
Open
maziyarpanahi wants to merge 1 commit into
maziyarpanahi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adds deterministic, local-only length budgeting for clinical-summary
generation. A closed policy allocates explicit output-token caps across
approved evidence classes and returns value-free truncation metadata naming
classes whose requested evidence was deferred.
Type of Change
Changes Made
clinical_summary_v1policy with safety-first priority,minimum/maximum bounds, and deterministic weighted allocation.
SummaryTruncationMetadatawithdeferred class identifiers, counts, fixed statuses, and clinician-review
guardrails.
values, and performs no model loading or mandatory network call.
Testing
Exact local validation:
.venv/bin/python -m pytest tests/unit/clinical/test_summary_length_budget.py -q— 7 passed.venv/bin/python -m pytest tests/unit/clinical/test_summary_length_budget.py tests/unit/clinical/test_summary_card.py tests/unit/clinical/test_citation_ordering.py -q— 35 passed.venv/bin/python -m mypy openmed/clinical/summary_length_budget.py— passed.venv/bin/python -m py_compile openmed/clinical/summary_length_budget.py tests/unit/clinical/test_summary_length_budget.py— passedmake format— passed; 2036 files left unchangedmake lint— passedmake format-check— passed; 2036 files already formattedmake docs-build— passed, including strict MkDocs staging and publication validationgit diff --check— passedChecks intentionally not run: the full repository test suite, model-backed or
benchmark checks, Swift checks (no Swift files changed), and remote CI waiting.
Documentation
Code Quality
make format,make lint, andmake format-checkmake format-swiftandmake lint-swiftDependencies
Checklist
Related Issues
Closes #2706
Screenshots/Examples
The synthetic API and truncation examples are covered in
tests/unit/clinical/test_summary_length_budget.pyanddocs/clinical/summary-length-budgets.md; no patient or restricted data isused.