Skip to content

Conversation

@DonLakeFlyer
Copy link
Contributor

  • Moved guided action confirmation into toolbar to prevent it from obscuring main view area
  • The descriptive text does show in the main area but it will fade out after a short amount of time to get out of the way

Screenshot 2025-12-08 at 10 03 06 AM
Screenshot 2025-12-08 at 10 02 57 AM

Copilot AI review requested due to automatic review settings December 8, 2025 18:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restructures the guided action confirmation UI to display it in the toolbar rather than overlaying the main view area. The confirmation button is placed in the center panel of the toolbar, while the descriptive message text appears below the toolbar and fades out after a short time to minimize visual obstruction.

Key Changes:

  • Moved GuidedActionConfirm component from FlyViewWidgetLayer to FlyViewToolBar
  • Redesigned toolbar layout with three panels (left, center, right) using a horizontal Row layout
  • Created message display component that fades after 4 seconds to reduce UI clutter

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
src/QmlControls/QGCPalette.h Removed unused toolbarDivider color definition
src/QmlControls/QGCPalette.cc Removed unused toolbarDivider color declaration
src/QmlControls/QGCCheckBox.qml Changed text color from qgcPal.text to qgcPal.buttonText for better toolbar visibility; improved property reference clarity
src/QmlControls/MainStatusIndicator.qml Simplified ready status text to just "Ready" (removed vehicle type differentiation)
src/QmlControls/FlyViewToolBarIndicators.qml Changed from anchors-based sizing to implicit width for better layout flexibility
src/QmlControls/FlyViewToolBar.qml Major refactoring: Restructured to three-panel layout (left/center/right), integrated GuidedActionConfirm, added message display with fade animation
src/FlyView/GuidedActionsController.qml Standardized message formatting by removing trailing periods and improving capitalization consistency
src/FlyView/GuidedActionConfirm.qml Converted from Rectangle to Item, changed from vertical to horizontal layout, removed internal message display (now external)
src/FlyView/FlyViewWidgetLayer.qml Removed GuidedActionConfirm instance (moved to toolbar) and utmspActTrigger property
src/FlyView/FlyView.qml Added required properties for FlyViewToolBar (guidedValueSlider, utmspSliderTrigger)

@DonLakeFlyer DonLakeFlyer merged commit a808b15 into master Dec 9, 2025
27 checks passed
@DonLakeFlyer DonLakeFlyer deleted the ToolbarConfirm branch December 9, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants