Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 8, 2025

Description

The GuidedValueSlider was anchored to parent.top without margin, causing it to render behind the toolbar.

Added anchors.topMargin: toolbar.height + _widgetMargin following the existing pattern from widgetLayer. This positions the slider below the toolbar with consistent visual spacing.

Changed:

  • src/FlyView/FlyView.qml line 170: Added topMargin anchor property
GuidedValueSlider {
    id:                 guidedValueSlider
    anchors.right:      parent.right
    anchors.top:        parent.top
    anchors.bottom:     parent.bottom
    anchors.topMargin:  toolbar.height + _widgetMargin  // Added
    z:                  QGroundControl.zOrderTopMost
    visible:            false
}

Test Steps

  1. Launch QGroundControl
  2. Connect to a vehicle and enter FlyView
  3. Trigger a guided action that displays the GuidedValueSlider (e.g., altitude change)
  4. Verify slider appears below toolbar, not behind it

Checklist:

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Original prompt

This section details on the original issue you should resolve

<issue_title>GuidedValueSlider goes up behind the toolbar</issue_title>
<issue_description></issue_description>

<agent_instructions>The top of the GuidedValueSlider should be anchored to the bottom of the toolbar</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Fix GuidedValueSlider positioning behind the toolbar Fix GuidedValueSlider overlapping toolbar Dec 8, 2025
Copilot AI requested a review from DonLakeFlyer December 8, 2025 17:15
@DonLakeFlyer DonLakeFlyer marked this pull request as ready for review December 10, 2025 18:52
Copilot AI review requested due to automatic review settings December 10, 2025 18:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a UI layout bug where the GuidedValueSlider component was rendering behind the toolbar in FlyView. The fix adds a top margin calculation that accounts for the toolbar height, ensuring the slider appears below the toolbar with appropriate spacing.

  • Added anchors.topMargin property to GuidedValueSlider using the established pattern toolbar.height + _widgetMargin
  • This matches the existing layout pattern used by widgetLayer (line 128)
  • The fix is minimal and follows QGC's QML anchoring conventions

@DonLakeFlyer DonLakeFlyer merged commit 3790c92 into master Dec 10, 2025
20 checks passed
@DonLakeFlyer DonLakeFlyer deleted the copilot/fix-guided-value-slider-position branch December 10, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GuidedValueSlider goes up behind the toolbar

2 participants