Use new name for ArduPlane RTL altitude in all Safety components

[Maarrk]

Description

Use the correct RTL_ALTITUDE parameter for ArduPlane > 4.5.

Reuses logic introduced to other QML files referencing ALT_HOLD_RTL.
It was originally done in 2db7285 PR #12195, but this file wasn't changed then.

Test Steps

1. Connect ArduPlane 4.6 or newer
2. Open QGC logo -> Vehicle Configuration -> Safety
3. Set "Return at specified altitude:" to some positive value
4. Open Summary tab
5. Check the value in "RTL min alt:" row - should be the same as set in step 3, but is missing without this fix

Checklist:

• Review Contribution Guidelines.
• Review Code of Conduct.
• I have tested my changes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Contribution on behalf of @FlyfocusUAV

[DonLakeFlyer]

So in looking at this, both this change and #12195 were not done correctly. They should be using the built in FirmwarePlugin::paramNameRemapMajorVersionMap functionality to provide parameter name remapping between versions. This way the qml code only needs to be updated once to use the "r.FOO" variants of parameter names and then the FirmwarePlugin will switch to the right parameter name based on firmware version.

[Maarrk]

Thanks @DonLakeFlyer! I'll update this and have a look for other spots where this should be changed.

[DonLakeFlyer]

I'll update this and have a look for other spots where this should be changed.

Awesome, thanks so much

[Maarrk]

I had a look through 4.5 release notes and searched the codebase for any usage of renamed parameters, only ALT_HOLD_RTL and ARSPD_FBW_{MIN|MAX} were used.
https://github.com/ArduPilot/ardupilot/blob/fbf146fc357d35aef28c7816df93db40d1729464/ArduPlane/ReleaseNotes.txt#L1224-L1242

7) Parameters renamed and rescaled
    - COMPASS_TYPEMASK renamed to COMPASS_DISBLMSK
    - SYS_NUM_RESETS replaced by STAT_BOOTCNT
    - AIRSPEED_CRUISE replaces TRIM_ARSPD_CM
    - AIRSPEED_MIN replaces ARSPD_FBW_MIN
    - AIRSPEED_MAX replaces ARSPD_FBW_MAX
    - CRUISE_ALT_FLOOR replaces ALT_HOLD_FBWCM
    - LAND_FINAL_SPD replaces LAND_SPEED
    - LAND_PITCH_DEG replaces LAND_PITCH_CD
    - MIN_GROUNDSPEED replaces MIN_GNDSPD_CM
    - PTCH_LIM_MAX_DEG replaces LIM_PITCH_MAX
    - PTCH_LIM_MIN_DEG replaces LIM_PITCH_MIN
    - PTCH_TRIM_DEG replaces TRIM_PITCH_CD
    - Q_LAND_FINAL_SPD replaces Q_LAND_SPEED
    - Q_PILOT_ACCEL_Z replaces Q_ACCEL_Z
    - Q_PILOT_SPD_UP replaces Q_VELZ_MAX
    - Q_PILOT_SPD_DN replaces Q_VELZ_MAX_DN
    - ROLL_LIMIT_DEG replaces LIM_ROLL_CD
    - RTL_ALTITUDE replaces ALT_HOLD_RTL

Also there I checked that ArduPilot team didn't rename any parameters in 4.6, should I bump this number? I believe they don't do breaking changes to parameters on patch releases.

qgroundcontrol/src/FirmwarePlugin/APM/ArduPlaneFirmwarePlugin.cc

Lines 95 to 99 in fa3ee73

	int ArduPlaneFirmwarePlugin::remapParamNameHigestMinorVersionNumber(int majorVersionNumber) const
	{
	// Remapping supports up to 4.5
	return ((majorVersionNumber == 4) ? 5 : Vehicle::versionNotSetValue);
	}

---

I also searched for firmwareMajorVersion to detect other renames handled the incorrect way. The only remaining result related to parameters is in PX4 SensorsComponent. But I don't have experience with PX4 and a simple replacement won't be enough there, so I'd rather not touch it.

[Maarrk]

I have confirmed the RTL altitude works correctly everywhere in GUI with ArduPlane 4.6, but can't test 4.4 to ensure the remapping works, because of Python problems with sim_vehicle.py, sorry.

But I consider this tested enough, because the remapping system was already tested with airspeed.

[DonLakeFlyer]

This looks all good, thanks so much. I'm just gonna do a quick SITL test as well and then merge.