Skip to content

Derive additional action availability from model #13639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rubenp02 wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −3
Open

Derive additional action availability from model #13639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/FlightDisplay/FlyViewAdditionalActionsList.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,15 @@ import QtQml
QtObject {
property var guidedController

property bool anyActionAvailable: guidedController.showStartMission || guidedController.showContinueMission || guidedController.showChangeAlt ||
guidedController.showChangeLoiterRadius || guidedController.showLandAbort || guidedController.showChangeSpeed
property bool anyActionAvailable: {
for (var i = 0; i < model.length; i++) {
if (model[i].visible)
return true
}

return false
}
Copy link
Contributor

@DonLakeFlyer DonLakeFlyer Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this ends up being re-triggered when a visible property on one of the model items changes value?


property var model: [
{
title: guidedController.startMissionTitle,
Expand Down
10 changes: 9 additions & 1 deletion src/FlightDisplay/FlyViewAdditionalCustomActionsList.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,14 @@ Item {

property var guidedController

property bool anyActionAvailable: false
property bool anyActionAvailable: {
for (var i = 0; i < model.length; i++) {
if (model[i].visible)
return true
}

return false
}

property var model: [ ]
}
Loading