LogFiles fixup #2654
Merged
LogFiles fixup #2654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JonasVautherin
previously approved these changes
Sep 14, 2025
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/using-mavsdk-python-example-script-to-download-logs/47579/2 |
This implements proper re-requesting of missing data, instead of just trying the full chunk again.
This fixes download from PX4 via UDP where UDP sends too much at once filling up the Linux UDP buffer and causing us to lose data.
In case we don't receive the full list, we should re-request the missing ones.
julianoes
force-pushed
the
pr-logfiles-fixup
branch
from
3e80fa6 to
a41be31
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several issues with LogFiles: