More camera server functionality #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tbago
commented
Jun 16, 2023
•
tbago
commented
- add start and stop video function, add sample code for start stop video.
- add start and stop video streaming function, add stream id int camera side (the camera can support multi video streaming).
- storage functions
- capture status
- param changed subscriptions
julianoes
reviewed
Jun 16, 2023
|
Ok I will update the proto submodule, but not for now. I have more function need commit. |
|
Add basic camera function complete. When the proto repo is accept, will update the submodule, and complete this PR. Other camera function will implement in new PR later. |
|
Thanks @tbago, let me review the proto PR again. |
|
@julianoes Yeah, you don't need review this PR until the Mavsdk-Proto is ready. For now may need to add more unit tests for camera server. |
julianoes
force-pushed
the
add_more_camera_function
branch
from
bf02a0c to
07db38f
Compare
julianoes
force-pushed
the
pr-consolidate-components
branch
from
e767e7a to
7e30cfb
Compare
julianoes
force-pushed
the
add_more_camera_function
branch
from
07db38f to
0933308
Compare
julianoes
force-pushed
the
add_more_camera_function
branch
from
0933308 to
7f00e5e
Compare
julianoes
force-pushed
the
add_more_camera_function
branch
from
1f15c2d to
a4edbd4
Compare
Signed-off-by: Julian Oes <[email protected]>
This required the MAVLink headers to be updated. Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
I don't understand what this should be doing. I don't think it's right. Signed-off-by: Julian Oes <[email protected]>
The sleeps were required because forwarding is broken in PX4. This will hopefully be fixed with PX4 v1.14.1. Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
And keep track of the state properly. Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
This enables servers to be notified when a param changes. Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
We ought to have a request. Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
julianoes
force-pushed
the
add_more_camera_function
branch
from
a4edbd4 to
e07d875
Compare
Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
julianoes
force-pushed
the
add_more_camera_function
branch
from
f09e16b to
c8d3afb
Compare
Signed-off-by: Julian Oes <[email protected]>
JonasVautherin
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.