Pass arguments to docker-run.sh on to mautrix-signal#485
Closed
BVollmerhaus wants to merge 3 commits intomautrix:mainfrom
BVollmerhaus:docker-argument-passthrough
Closed
Pass arguments to docker-run.sh on to mautrix-signal#485BVollmerhaus wants to merge 3 commits intomautrix:mainfrom BVollmerhaus:docker-argument-passthrough
BVollmerhaus wants to merge 3 commits intomautrix:mainfrom
BVollmerhaus:docker-argument-passthrough
Conversation
Author
|
@tulir Hey, could you have a look? 🙂 I think this would be quite useful for Dendrite users in particular. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends
docker-run.shso that it passes additional arguments on to mautrix-signal (once the requisite files exist and the bridge is started). In particular, this should make it easier to use CLI flags such as--ignore-unsupported-serverwhen using the Docker image (by overridingCMD).Further, it fixes some inconsistent indentation and ShellCheck warnings concerning missing variable quoting.
Closes #474