Add Remix Inspired "Flat Routing"#36
Open
Zurdge wants to merge 3 commits intomatthiaaas:mainfrom
Open
Conversation
Owner
|
Thank you for the contribution @Zurdge, great idea. I am very curious on whether or not this is something where there is a significant need for. Maybe a modular approach which lets more space for custom routing strategies makes sense so people can come up with individual file naming conventions. Following a strategy pattern or similar, a significant refactor may be required. I am imagining an API like: import { DirectoryStrategy, FlatStrategy } from "express-file-routing"
createRouter(app, {
strategy: new DirectoryStrategy() // this might be the default directory-file-based strategy like Next.js
}Therefore, an strategy interface for generating the routes needs to be defined. What do you think? |
Author
|
Yeh I think this is a good idea! When I next get time, I'll try and scope out what this enhancement might look like and reply in this thread. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to structure my API routes in a flat directory, similar to how Remix handles it's routing.
https://remix.run/docs/en/main/discussion/routes#conventional-route-configuration
Would it be ok to implement something similar to this?
I've tested for my own needs and it works well. Happy to make adjustments 👍