forked from nipy/nipy
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ds105 analysis #1
Open
jonathan-taylor
wants to merge
195
commits into
matthew-brett:placeholder
Choose a base branch
from
jonathan-taylor:ds105_analysis
base: placeholder
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ds105 analysis #1
jonathan-taylor
wants to merge
195
commits into
matthew-brett:placeholder
from
jonathan-taylor:ds105_analysis
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows raised an error, apparently because of undeleted objects with references to temporary files.
Scripts were using outdated imageformats import, now failing.
ENH: Make it possible to input slice_order=None to FmriRealign4d This should fix issue nipy#228.
BF: fixed bug in resampling for unsigned type images This branch fixes a bug in the resample function from nipy.algorithms.registration, which returns an image with same dtype as the input image, meaning that any interpolated value needs be converted to the closest value according to the dtype. The conversion was not done properly for images encoded in unsigned integer types as negative values (which can arise here and there due to cubic spline interpolation) would be converted using a simple cast in C. This has been fixed by checking dtype.kind and forcing negative values to zero whenever dtype.kind=='u'.
Fix roi glm example This PR solves both issue nipy#224 and a random failure of the example.
…n quantile C-routine
Make single test functions run many tests.
RF: extend quantile and median tests Make single test functions run many tests.
Refactor quantile routine
…cit variable naming
The buildbots build mpkgs; this script builds dmgs from the mpkgs and sets the permissions correctly.
Fetched from the dipy/tools directory.
That I missed somehow.
From comments by Bertrand
We were pointing to the old deprecated function.
The ``screens`` utility assumed time last and slice second-to-last. Get screens to look for 't' axis (will nearly always be last, but often set), or accept suggestion from arguments; ditto for slice axis.
Add tests for slice axis and time axis specified. This is minor API breakage, because previous default behavior was: time_axis=-2, slice_axis default -> -2 time_axis=0, slice_axis_default -> -2 Now: time_axis=-2, slice_axis default -> -1 time_axis=0, slice_axis_default -> -1
Allow nipy_diagnose to work on arbitrary slice axis
DOC: fix a typo: "their is" -> "there is"
NF: add script to build dmg files from buildbots The buildbots build mpkgs; this script builds dmgs from the mpkgs and sets the permissions correctly.
MRG: Fix type graph This PR aims at solving issue nipy#256 by casting to float 64 the arrays that need to. I took this opportunity to clean the tests in nipy.algorithms.graph.
because we're set up properly on nipy.org now.
MRG: Screens refactor I found a dataset that had the slice dimension first (the Haxby 2001 datset, ds105 on OpenFMRI.org). To do slice timing we need to be able to specify the slice dimension. These changes allow you to specify the slice dimension to the utilities for time series differences (which depend on slice).
MRG: Fix bsa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've managed to get (what I think is) an appropriate single run model going. For the FIAC data, we had actually used warped fMRI which doesn't seem included in this data, unless I'm mistaken.
Added a block_design function that might be useful for other studies.