Ruby 1.8.6 didn;t seem to like my define methods, added class_eval st…

…rings, not as nice though
matth · Jun 16, 2010 · 2fb0680 · rkh · Jun 16, 2010 · rkh
1 parent a344e5e
commit 2fb0680
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -22,7 +22,7 @@ Install the software (for more info see the Installation section) and run with:
 
     ruby mayapp.rb
 
-View your graph at [http://localhost/a\_graph\_of\_various\_fruit.png](http://localhost/a_graph_of_various_fruit.png)
+View your graph at [http://localhost:4567/a\_graph\_of\_various\_fruit.png](http://localhost:4567/a_graph_of_various_fruit.png)
 
 ## Installation
 

diff --git a/chart-topper.gemspec b/chart-topper.gemspec
@@ -1,7 +1,7 @@
 
 Gem::Specification.new do |s|
   s.name = "chart-topper"
-  s.version = "0.0.1"
+  s.version = "0.0.2"
   s.author = "Matt Haynes"
   s.email = "[email protected]"
   s.homepage = "http://github.com/matth/chart-topper/tree/master"

diff --git a/examples/a_simple_line_chart.png b/examples/a_simple_line_chart.png
diff --git a/examples/simple.rb b/examples/simple.rb
@@ -52,7 +52,7 @@
 # BAR CHART /a_simple_bar_chart.png
 bar "A simple bar chart" do
 
-  size "400x225"
+  size params["size"] || "400x225"
 
   data "Apples",     40
   data "Oranges",    50

diff --git a/lib/sinatra/chart_topper.rb b/lib/sinatra/chart_topper.rb
@@ -11,12 +11,19 @@ module ChartTopper
                     :pie, :side_stacked_bar, :side_bar, :spider, :stacked_area, :stacked_bar]
 
     GRAPH_TYPES.each do |method|
-      define_method(method) do |*args, &block|
-        title, options = *args
-        options ||= {}
-        camelized = method.to_s.split('_').map {|w| w.capitalize}.join
-        draw Gruff.const_get(camelized), title, options, &block
-      end      
+      # Ruby 1.8.6 doesn't seem to like this ???
+      # define_method(method) do |*args, &block|
+      #   title, options = *args
+      #   options ||= {}
+      #   camelized = method.to_s.split('_').map {|w| w.capitalize}.join
+      #   draw Gruff.const_get(camelized), title, options, &block
+      # end                                                      
+      camelized = method.to_s.split('_').map {|w| w.capitalize}.join      
+      class_eval <<-EVAL
+        def #{method.to_s}(title, options ={}, &block)
+          draw #{Gruff.const_get(camelized)}, title, options, &block
+        end
+      EVAL
     end
 
     # Delegate(?) these methods to the graph