Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-898]: Fixed TS errors in multiple webapp files #1133

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[MM-898]: Fixed TS errors in multiple webapp files #1133

wants to merge 3 commits into from

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

Fixed TS errors in multiple webapp files

What to Test

  • Test the major functionalities related to creating and issue and subscription

@Kshitij-Katiyar Kshitij-Katiyar self-assigned this Oct 30, 2024
@Kshitij-Katiyar Kshitij-Katiyar added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Oct 30, 2024
@Kshitij-Katiyar Kshitij-Katiyar mentioned this pull request Oct 30, 2024
Merged
@wiggin77
Copy link
Member

@raghavaggarwal2308 @Kshitij-Katiyar there seems to be a problem with CI failing on several PRs. Can someone take a look and fix master?

@Kshitij-Katiyar
Copy link
Contributor Author

@raghavaggarwal2308 @Kshitij-Katiyar there seems to be a problem with CI failing on several PRs. Can someone take a look and fix master?

@wiggin77 The CI is fixed now

@raghavaggarwal2308 raghavaggarwal2308 modified the milestones: v4.2.0, v4.3.0 Jan 16, 2025
@raghavaggarwal2308 raghavaggarwal2308 removed the 2: Dev Review Requires review by a core committer label Jan 16, 2025
@Kshitij-Katiyar
[MM-959]: Added type for redux store and resolved some TS errors (#1140)
42a472f 
* [MM-959]: Added type for redux store

* [MM-983]: Resolved TS errors in action and disconnect modal files (#1141)
AayushChaudhary0001
AayushChaudhary0001 reviewed Feb 25, 2025
View reviewed changes
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested for the code changes and all the basic functionalities are working fine for both Jira cloud and Jira server instance, LGTM. Approved.

@raghavaggarwal2308 raghavaggarwal2308 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiggin77 wiggin77 wiggin77 approved these changes

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@AayushChaudhary0001 AayushChaudhary0001 AayushChaudhary0001 approved these changes

Assignees

@Kshitij-Katiyar Kshitij-Katiyar

Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v4.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Kshitij-Katiyar @wiggin77 @raghavaggarwal2308 @AayushChaudhary0001