Only fetch bookmarks when the license allows to use them #8616
Conversation
larkox
requested review from
a team and
hanzei
and removed request for
a team
|
/update-branch |
|
@yasserfaraazkhan The tests for this is just making sure the bookmarks are working as they should, changes in the license are properly handled, and that on unlicensed servers you don't get in the log errors on every channel switch about not having a license for bookmarks. |
| if (!bookmarksEnabled) { | ||
| const license = await getLicense(database); | ||
|
|
||
| if (!bookmarksEnabled || license?.IsLicensed !== 'true') { |
There was a problem hiding this comment.
Why
IsLicensed !== `true`
means that we should not enabled bookmark? Perhaps an explanation via comment is necessary here?
There was a problem hiding this comment.
I moved around the variables to clarify the condition.
IsLicensed !== 'true' means the server is not licensed. And you need a license to use channel bookmarks.
yasserfaraazkhan
added
Build Apps for PR
|
95 % passed just 11 failed |
|
@yasserfaraazkhan Doesn't look like any of those e2e test are related to this PR. Is it possible they are failing on master? |
|
ohh no @larkox sorry I didn't give context 😀 I'm manually testing failed ones and some more tests as you suggested. Will update about the PR. |
Summary
On an unlicensed server, on development, we show errors because the bookmarks functionality is not available without a license.
To avoid these errors, we just check the license before fetching the bookmarks (and we do one less unneeded request).
Ticket Link
NONE
Release Note