Add Report a Problem functionality #8605
Conversation
larkox
added
2: Dev Review
| {filename} | ||
| </Text> | ||
| <Text style={styles.logSize}> | ||
| {`TXT ${size}KB`} |
There was a problem hiding this comment.
There is a helper function to get the size as a string https://github.com/mattermost/mattermost-mobile/blob/main/app/utils/file/index.ts#L311
| @@ -117,12 +117,24 @@ - (NSDictionary *)constantsToExport { | |||
| [self getRealFilePath:filePath resolve:resolve reject:reject]; | |||
| } | |||
|
|
|||
| RCT_EXPORT_METHOD(getFileSize:(NSString *)filePath | |||
| fos.close() | ||
| promise?.resolve(zipFile.absolutePath) | ||
| } catch (e: Exception) { | ||
| promise?.reject("Error creating ZIP file", e) |
There was a problem hiding this comment.
Should we attempt to delete the tempDir and contents if there is an error?
| @@ -52,6 +52,7 @@ export interface Spec extends TurboModule { | |||
| removeListeners: (count: number) => void; | |||
|
|
|||
| getRealFilePath: (filePath: string) => Promise<string>; | |||
| getFileSize: (filePath: string) => Promise<number>; | |||
There was a problem hiding this comment.
Adding a comment here so that is not forgotten when removed
test/setup.ts
Outdated
| deleteFile: jest.fn(), | ||
| getFileSize: jest.fn().mockResolvedValue(100), |
abhijit-singh
added
the
Build Apps for PR
|
/update-branch |
| @@ -58,7 +58,8 @@ dependencies { | |||
| implementation 'androidx.window:window:1.2.0' | |||
| implementation 'androidx.window:window-core:1.2.0' | |||
| implementation 'androidx.window:window-rxjava3:1.2.0' | |||
|
|
|||
| implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.1' | |||
There was a problem hiding this comment.
this is causing snyk to fail, I think a new version needs to be used
There was a problem hiding this comment.
Thank you! For some reason I am having trouble logging in into snyk...
| <ScrollView | ||
| horizontal={true} | ||
| contentContainerStyle={styles.logsContainer} | ||
| showsHorizontalScrollIndicator={false} |
There was a problem hiding this comment.
should we set alwaysBounceHorizontal to false when loading or when the items are less than x?
Summary
Add report a problem functionality. This needs a particular server version to show all the capabilities (see related PR).
Figma file: https://www.figma.com/design/vd5328lXOFcEdLkKT6Mlrg/MM-61217-Report-a-problem-UX?node-id=1-7
More information in the ticket
Ticket Link
Fix: https://mattermost.atlassian.net/browse/MM-61217
Related PR
Server/Web: Coming soon
Release Note