feat: Add support for AWS role assumption in deployment configuration #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces an optional AWSRoleARN field to the deployment Config struct, allowing users to specify an IAM role to assume during AWS operations. The GetAWSConfig method in the Terraform utility has been updated to support role assumption using AWS SDK v2 credentials.
There was a problem hiding this comment.
Thank you! Can you add the AWSRoleARN we need to the examples/config/ci/deployer.json file so that the pipeline gets it (that's the set of files used in the pipeline)? I'll change https://github.com/mattermost/delivery-platform/pull/251 to use this branch to test it.
fmartingr
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change introduces an optional AWSRoleARN field to the deployment Config struct, allowing users to specify an IAM role to assume during AWS operations. The GetAWSConfig method in the Terraform utility has been updated to support role assumption using AWS SDK v2 credentials.
Ticket Link
https://mattermost.atlassian.net/browse/CLD-8926