fix(MM-62375) OOM on gif with build updates #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahimrahman
added
the
Do Not Merge
|
@larkox @enahum I'm inviting you to review this PR and please approve it (even if it won't get merged) or you can suggest a different method to fix the problem. I won't change any minor formatting/whitespace since I will do that in the other PR. The real PR to be merged upstream will be this: #2 (it's showing the base is mattermost for now but I will change that to the upstream repo) |
5 tasks
enahum
approved these changes
Feb 10, 2025
larkox
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not merge, as this branch is being used and cloned into Mattermost-Mobile. It contains all the changes necessary to fix the issue, but with added build.gradle changes to ensure successful build in that project.
Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-62375
Mattermost Mobile PR: mattermost/mattermost-mobile#8573