fix: base token attributes #375
Open
+95
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petarTxFusion
changed the title
API E2E Test Results207 tests 207 ✅ 19s ⏱️ Results for commit 1e00904. ♻️ This comment has been updated with latest results. |
Unit Test Results 4 files 263 suites 12m 1s ⏱️ Results for commit 1e00904. ♻️ This comment has been updated with latest results. |
|
Visit the preview URL for this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Import base token attributes from config
Why ❔
For custom chains base token attributes are read from contract which is incorrect. Contract always contains
EtherattributesChecklist
This PR fixes: #335
[+] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[+] Tests for the changes have been added / updated.
Documentation comments have been added / updated.